merge queue: checking #10001 on unstable (f93875f) - #10021
Closed
mergify[bot] wants to merge 5 commits into
Closed
Conversation
If the EL blob fetch wins the block import race, queued attestations never receive the import notification and attestation_to_unknown_block_processed_after_gossip_block can time out. Reuse the column import notification helper so this path also releases waiting work, including payload attestations after Gloas.
Process the Fulu block without its columns before explicitly fetching blobs from the EL. Assert that the block becomes head and its queued attestation is reprocessed and imported. This deterministically fails when the EL import notification is missing.
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#10001 is queued for merge on branch unstable (f93875f).
This pull request has been created by Mergify to check the mergeability of #10001.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:check-success=local-testnet-successcheck-success=test-suite-successgithub-review-approved[🛡 GitHub branch protection]Required conditions to stay in the queue:
#approved-reviews-by >= 1check-success=license/clacheck-success=target-branch-checkgithub-review-approved[🛡 GitHub branch protection]label!=do-not-merge